Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster BooleanBufferBuilder::append_n for true values #3596

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Inspired by #1603. The performance benefits are clearly visible when decoding nullable primitive values from parquet, where it yields a non-trivial speedup

arrow_array_reader/Int64Array/binary packed, mandatory, no NULLs
                        time:   [17.706 µs 17.711 µs 17.718 µs]
                        change: [+6.7854% +6.8707% +6.9525%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 6 outliers among 100 measurements (6.00%)
  6 (6.00%) high mild
arrow_array_reader/Int64Array/binary packed, optional, no NULLs
                        time:   [18.660 µs 18.678 µs 18.710 µs]
                        change: [-37.996% -37.947% -37.880%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
  3 (3.00%) high mild
  1 (1.00%) high severe
arrow_array_reader/Int64Array/binary packed skip, mandatory, no NULLs
                        time:   [16.585 µs 16.595 µs 16.608 µs]
                        change: [+5.0752% +5.1957% +5.3004%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 6 outliers among 100 measurements (6.00%)
  3 (3.00%) high mild
  3 (3.00%) high severe
arrow_array_reader/Int64Array/binary packed skip, optional, no NULLs
                        time:   [17.200 µs 17.207 µs 17.214 µs]
                        change: [-27.663% -27.598% -27.528%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
  4 (4.00%) high mild
  2 (2.00%) high severe
arrow_array_reader/Int64Array/binary packed, optional, half NULLs
                        time:   [29.343 µs 29.349 µs 29.356 µs]
                        change: [+4.4487% +4.5826% +4.6903%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 12 outliers among 100 measurements (12.00%)
  7 (7.00%) high mild
  5 (5.00%) high severe

Note the regressions are just noise, they fluctuate by ~8%.

What changes are included in this PR?

Are there any user-facing changes?

No

Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉

@tustvold tustvold merged commit 025ffd0 into apache:master Jan 24, 2023
@ursabot
Copy link

ursabot commented Jan 24, 2023

Benchmark runs are scheduled for baseline = b35e179 and contender = 025ffd0. 025ffd0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants