Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add crate badges #362

Merged
merged 2 commits into from
May 26, 2021
Merged

Add crate badges #362

merged 2 commits into from
May 26, 2021

Conversation

domoritz
Copy link
Member

Closes #361.

alamb
alamb approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thanks @domoritz

@codecov-commenter
Copy link

Codecov Report

Merging #362 (07eef2d) into master (1d72b26) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   82.59%   82.60%           
=======================================
  Files         162      162           
  Lines       44164    44164           
=======================================
+ Hits        36479    36480    +1     
+ Misses       7685     7684    -1
Impacted Files Coverage Δ
parquet/src/encodings/encoding.rs 95.04% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d72b26...07eef2d. Read the comment docs.

nevi-me
nevi-me approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@nevi-me nevi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nevi-me nevi-me merged commit 4a27a3b into apache:master May 26, 2021
alamb pushed a commit that referenced this pull request May 26, 2021
@domoritz @alamb
Add crate badges (#362)
648f0d3 
* Add crate badges

* Format markdown
@alamb alamb mentioned this pull request May 26, 2021
Merged
nevi-me pushed a commit that referenced this pull request May 27, 2021
@alamb @domoritz
Add crate badges (#362) (#373)
58d53cf 
* Add crate badges

* Format markdown

Co-authored-by: Dominik Moritz <domoritz@gmail.com>
@alamb alamb mentioned this pull request May 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevi-me nevi-me nevi-me approved these changes

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add badges to crates
4 participants
@domoritz @codecov-commenter @alamb @nevi-me