Add doctest for ArrayBuilder #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #367 +/- ##
==========================================
+ Coverage 82.56% 82.60% +0.04%
==========================================
Files 162 162
Lines 44063 44175 +112
==========================================
+ Hits 36379 36490 +111
- Misses 7684 7685 +1
Continue to review full report at Codecov.
|
Dandandan
approved these changes
May 29, 2021
alamb
approved these changes
May 29, 2021
| /// .downcast_ref::<StringArray>() | ||
| /// .unwrap() | ||
| /// .value(0), | ||
| /// "🍎" |
|
The MIRI failure is unrelated to the content of this PR (we disabled it until we can figure out why it is failing intermittently) |
alamb
pushed a commit
that referenced
this pull request
Jun 4, 2021
alamb
added a commit
that referenced
this pull request
Jun 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #366.
Rationale for this change
Increasing the docs coverage.
What changes are included in this PR?
A doctest for creating a
VecofArrayBuilders in order to get aVecofArrayRefsAre there any user-facing changes?
No. Docs added. It's a non-breaking change.