Add into_primitive_dict_builder to DictionaryArray
#3715
Conversation
| let key_array = as_primitive_array::<K>(self.keys()).clone(); | ||
| let value_array = as_primitive_array::<V>(self.values()).clone(); | ||
|
|
||
| drop(self.data); |
There was a problem hiding this comment.
is this needed to drop the ref counts to be able to call into_builder() without copying data (as self has a ref count)?
There was a problem hiding this comment.
Yea, this drops self ref count.
| match err { | ||
| Ok(_) => panic!("Should not get builder from cloned array"), | ||
| Err(returned) => { |
There was a problem hiding this comment.
You could also write this like let returned = err.unwrap_err()
viirya
force-pushed
the
into_primitive_dict_builder
branch
from
fa623d7 to
b8dbf61
Compare
|
Benchmark runs are scheduled for baseline = e52574c and contender = 72474a6. 72474a6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Part of #3710.
Rationale for this change
Similar to
into_builderofPrimitiveArray,into_primitive_dict_builderis for cow support forDictionaryArray.With this API, it is easy to add
unary_dict_mut.What changes are included in this PR?
Added
into_primitive_dict_builderAPI toDictionaryArrayfor mutating its keys and values.Are there any user-facing changes?