Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctests for FixedSizeBinaryArray #378

Merged
merged 5 commits into from
May 29, 2021
Merged

Doctests for FixedSizeBinaryArray #378

merged 5 commits into from
May 29, 2021

Conversation

novemberkilo
Copy link
Contributor

Which issue does this PR close?

re #301

Rationale for this change

Additional test coverage and documentation

Are there any user-facing changes?

No

@novemberkilo
Copy link
Contributor Author

// @alamb

@codecov-commenter
Copy link

Codecov Report

Merging #378 (2589e5b) into master (10100bb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2589e5b differs from pull request most recent head cff2530. Consider uploading reports for the commit cff2530 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   82.60%   82.60%           
=======================================
  Files         162      162           
  Lines       44199    44214   +15     
=======================================
+ Hits        36509    36525   +16     
+ Misses       7690     7689    -1     
Impacted Files Coverage Δ
arrow/src/array/array_binary.rs 90.15% <100.00%> (+0.29%) ⬆️
parquet/src/encodings/encoding.rs 95.04% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10100bb...cff2530. Read the comment docs.

@alamb
Copy link
Contributor

alamb commented May 29, 2021

The windows failure is unrelated to this PR

@alamb alamb merged commit d9017ee into apache:master May 29, 2021
alamb added a commit that referenced this pull request Jun 4, 2021
* Doctests for BooleanArray.

* Update arrow/src/array/array_boolean.rs

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>

* Doctests for FixedSizeBinaryArray.

* Fix formatting.

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
alamb added a commit that referenced this pull request Jun 5, 2021
* Doctests for BooleanArray.

* Update arrow/src/array/array_boolean.rs

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>

* Doctests for FixedSizeBinaryArray.

* Fix formatting.

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>

Co-authored-by: Navin <navin@cogent.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants