Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup ApplicationDefaultCredentials #3799

Merged
merged 2 commits into from
Mar 5, 2023

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Mar 3, 2023

Which issue does this PR close?

Relates to #3797

Rationale for this change

It was unclear how to extend the existing logic to support the different authentication flows, and the error messages were not always particularly clear on what the actual issue is.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the object-store Object Store Interface label Mar 3, 2023
@tustvold tustvold force-pushed the application-default-credentials branch from 1967a1b to 1c23a67 Compare March 3, 2023 12:06
@alamb
Copy link
Contributor

alamb commented Mar 3, 2023

cc @wjones127 @Samrose-Ahmed @winding-lines

Copy link
Contributor

@winding-lines winding-lines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the cleanup!

@tustvold tustvold merged commit 7eb588d into apache:master Mar 5, 2023
@ursabot
Copy link

ursabot commented Mar 5, 2023

Benchmark runs are scheduled for baseline = 79518cf and contender = 7eb588d. 7eb588d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants