Added support for byte vectors and slices to parquet_derive (#3864) #3878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Mar 17, 2023
|
I'll plan to merge this over the next few days unless there are other comments |
|
Thanks again @waymost -- this will be published to crates.io I think in about a week with the next regular arrow-rs release |
|
Thanks for merging this so quickly @alamb! |
|
👍 FYI #3889 tracks the release that will include this change |
spebern
pushed a commit
to spebern/arrow-rs
that referenced
this pull request
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3864.
Rationale for this change
parquet_derivewas missing some code to be able to handle byte vectors and slices in structs. The readme even currently states thatVec<u8>is supported even though it doesn't currently work.What changes are included in this PR?
This change enables support for
Vec<u8>,Option<Vec<u8>>,&Option<Vec<u8>>,&[u8], and&Option<&[u8]>inparquet_derive. All of these cases have been added to the integration test inparquet_derive_test.This fix required adding a
Slicevariant to theparquet_derive::parquet_field::Typeenum as well as implementingFrom<&[u8]>forparquet::data_type::ByteArray.Are there any user-facing changes?
No