Return ScalarBuffer from PrimitiveArray::values (#3879) #3896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Mar 21, 2023
| @@ -69,7 +69,7 @@ | |||
| //! | |||
| //! let collected: Vec<_> = array.iter().collect(); | |||
| //! assert_eq!(collected, vec![Some(1), None, Some(3)]); | |||
| //! assert_eq!(array.values(), [1, 0, 3]) | |||
| //! assert_eq!(array.values(), &[1, 0, 3]) | |||
There was a problem hiding this comment.
I couldn't work out how to make this work as before, tbh I'm somewhat confused how it was working before...
viirya
approved these changes
Mar 21, 2023
| @@ -277,7 +277,7 @@ impl<T: ArrowPrimitiveType> PrimitiveArray<T> { | |||
|
|
|||
| /// Returns a slice of the values of this array | |||
spebern
pushed a commit
to spebern/arrow-rs
that referenced
this pull request
Mar 25, 2023
…#3896) * Return ScalarBuffer from PrimitiveArray::values (apache#3879) * Fix docs * Review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3879
Rationale for this change
Continues the process of making arrays wrappers around strongly typed buffer abstractions, in a similar vein to #3895
What changes are included in this PR?
Are there any user-facing changes?
Yes, it changes the return type of PrimitiveArray::values. I opted to just break this API instead of deprecating, as I wanted to keep the name the same.