Cleanup uses of Array::data_ref (#3880) #3918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
tustvold
force-pushed
the
cleanup-uses-of-array-data
branch
from
13b9684 to
1ddbb77
Compare
alamb
reviewed
Mar 23, 2023
| @@ -1159,8 +1159,13 @@ pub struct LexicographicalComparator<'a> { | |||
| impl LexicographicalComparator<'_> { | |||
| /// lexicographically compare values at the wrapped columns with given indices. | |||
| pub fn compare(&self, a_idx: usize, b_idx: usize) -> Ordering { | |||
| for (data, comparator, sort_option) in &self.compare_items { | |||
| match (data.is_valid(a_idx), data.is_valid(b_idx)) { | |||
| for (nulls, comparator, sort_option) in &self.compare_items { | |||
There was a problem hiding this comment.
I checked at this seems to simply pull the match up a level https://docs.rs/arrow-data/35.0.0/src/arrow_data/data/mod.rs.html#384-389 (as in there is no more dynamic dispatch from what I can see)
alamb
approved these changes
Mar 23, 2023
| Some(nulls) => buffer_unary_not(nulls.buffer(), nulls.offset(), nulls.len()), | ||
| let values = match input.nulls() { | ||
| None => NullBuffer::new_null(input.len()).into_inner(), | ||
| Some(nulls) => !nulls.inner(), |
There was a problem hiding this comment.
these certainly do look very nice now 👌
|
The benchmarks do not show any major regressions, with most kernels completely unaffected. The boolean kernels seem to show a consistent 10% regression on some systems and a consistent 10% improvement on others, not entirely sure what is going on here but given we're talking 10s of nanoseconds I think it is probably just noise, and certainly not relevant to realistic workloads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3880
Rationale for this change
The first of likely multiple PRs to gradually remove the direct usage of
ArrayData::data_reffrom the kernelsWhat changes are included in this PR?
Are there any user-facing changes?