Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused type parameters. #3986

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

youngsofun
Copy link
Contributor

receive warning from cargo clippy.

Which issue does this PR close?

Closes #.

Rationale for this change

cargo clippy --future-incompat-report


warning: type parameter goes unused in function definition
  --> arrow-ord/src/ord.rs:48:18
   |
48 | fn compare_string<T>(left: &dyn Array, right: &dyn Array) -> DynComparator
   |                  ^^^
   |
   = help: consider removing the parameter
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
   = note: `#[warn(clippy::extra_unused_type_parameters)]` on by default

warning: type parameter goes unused in function definition
   --> arrow-ord/src/sort.rs:904:17
    |
904 | fn sort_list<S, T>(
    |                 ^
    |
    = help: consider removing the parameter
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Mar 31, 2023
receive warning from cargo clippy.
@youngsofun youngsofun force-pushed the warnings branch 2 times, most recently from d1b7f6f to f1437a0 Compare March 31, 2023 03:40
@tustvold tustvold merged commit 5691433 into apache:master Mar 31, 2023
@youngsofun youngsofun deleted the warnings branch March 31, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants