-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CAST from Decimal datatype to String #3994
Conversation
@tustvold not sure why the test fails on
Perhaps related to #3983 |
My guess is the cast is failing and inserting a null, but the field doesn't permit nulls. I'm not sure what the cast kernel should do in such a case tbh, but in the immediate term I'd suggest finding a way to avoid the decimal cast from failing |
@tustvold I have removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nits
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
I took the liberty of resolving the merge conflicts on this |
Which issue does this PR close?
Closes #3991.
Rationale for this change
Support cast Decimal datatype to string
What changes are included in this PR?
Are there any user-facing changes?
No