Handle precision overflow when casting from integer to decimal #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
changed the title
tustvold
approved these changes
Apr 1, 2023
arrow-cast/src/cast.rs
Outdated
| &DataType::Decimal128(7, 3), | ||
| &CastOptions { safe: false }, | ||
| ); | ||
| assert!(casted_array.is_err()); |
There was a problem hiding this comment.
Perhaps could check the error
comphead
reviewed
Apr 2, 2023
| @@ -358,13 +358,29 @@ where | |||
|
|
|||
| let array = if scale < 0 { | |||
| match cast_options.safe { | |||
| true => array.unary_opt::<_, D>(|v| v.as_().div_checked(scale_factor).ok()), | |||
| false => array.try_unary::<_, D, _>(|v| v.as_().div_checked(scale_factor))?, | |||
| true => array.unary_opt::<_, D>(|v| { | |||
This was referenced Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3995.
Rationale for this change
Although
castkernel checks if division or multiplication overflows in such cast operation, it doesn't check precision overflow. This is somehow related to decimal operation convention in arrow-rs, that is let user handle invalid values in decimal arrays. But forcastkernel, because it providesCastOptionswhich defines null behavior for invalid case, the behavior of not checking precision overflow becomes a bit inconsistent.What changes are included in this PR?
Are there any user-facing changes?