-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FlightSQL module docs and links to arrow-flight
crates
#4012
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b3841e1
Add FlightSQL module docs and links to `arrow-flight` crates
alamb 84f2b09
Updates
alamb 67a2cbd
Merge remote-tracking branch 'apache/master' into alamb/update_docsss
alamb 9cc4929
Update arrow-flight/src/sql/mod.rs
alamb 14b5edb
Merge branch 'alamb/update_docsss' of github.com:alamb/arrow-rs into …
alamb 7c8f3e1
Copy editing and improve links
alamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,27 @@ | |
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
//! Support for execute SQL queries using [Apache Arrow] [Flight SQL]. | ||
//! | ||
//! [Flight SQL] is built on top of Arrow Flight RPC framework, by | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This might be easier to read if the link anchors were moved to the end There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good idea -- done in 7c8f3e1 |
||
//! defining specific messages, encoded using the protobuf format, | ||
//! sent in the[`FlightDescriptor::cmd`] field to [`FlightService`] | ||
//! endpoints such as[`get_flight_info`] and [`do_get`]. | ||
//! | ||
//! This module contains: | ||
//! 1. [prost] generated structs for FlightSQL messages such as [`CommandStatementQuery`] | ||
//! 2. Helpers for encoding and decoding FlightSQL messages: [`Any`] and [`Command`] | ||
//! 3. A [`FlightSqlServiceClient`] for interacting with FlightSQL servers. | ||
//! 4. A [`FlightSqlService`] to help building FlightSQL servers from [`FlightService`]. | ||
//! | ||
//! [Flight SQL]: https://arrow.apache.org/docs/format/FlightSql.html | ||
//! [Apache Arrow]: https://arrow.apache.org | ||
//! [`FlightDescriptor::cmd`]: crate::FlightDescriptor::cmd | ||
//! [`FlightService`]: crate::flight_service_server::FlightService | ||
//! [`get_flight_info`]: crate::flight_service_server::FlightService::get_flight_info | ||
//! [`do_get`]: crate::flight_service_server::FlightService::do_get | ||
//! [`FlightSqlServiceClient`]: client::FlightSqlServiceClient | ||
//! [`FlightSqlService`]: server::FlightSqlService | ||
use arrow_schema::ArrowError; | ||
use bytes::Bytes; | ||
use paste::paste; | ||
|
@@ -90,8 +111,8 @@ macro_rules! prost_message_ext { | |
)* | ||
|
||
as_item! { | ||
/// Helper to convert to/from protobuf [`Any`] | ||
/// to a strongly typed enum. | ||
/// Helper to convert to/from protobuf [`Any`] message | ||
/// to a specific FlightSQL command message. | ||
/// | ||
/// # Example | ||
/// ```rust | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to make this not experimental BTW. It's just a struct and impl in a library AFAIK, so it shouldn't hurt anyone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think we were just trying to give people the heads up that we would likely be making substantial changes to the API -- but then we do that with other parts of arrow, so maybe the extra "experimental" part is unecessary.
What do you think @tustvold / @viirya -- should we rename the feature flag from experimental (and maybe turn it on by default?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did we get to with an integration test of FlightSQL? I think that would help justify graduating this functionality perhaps?
I'm somewhat apprehensive there may still be areas we have interpreted the specification differently, one was fixed last week. The experimental flag allows us to "fix" such things without needing to preserve backwards compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I guess I was thinking we break backwards compatibility fairly regularly (as in there are several API changes per release)
So it isn't like I think the flight sql feature is fully ready and the API won't change -- more like I wonder if we should treat it specially from the rest of arrow-flight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We break Rust API compatibility for sure, protocol compatibility is a different beast imo, as providing an incremental migration story becomes very important for upgrades to actually be possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see -- you are perhaps imagining that the FlightSQL protocol itself may change, not just the rust implementation. The spec is marked as experimental in many places. 🤷
https://github.com/apache/arrow/blob/ad115be1214b13ce393537bdb9c34ae919e4997f/format/FlightSql.proto#LL46