Fix timestamp handling in cast kernel (#1936) (#4033) #4034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Apr 7, 2023
| /// Creates a ArrowTimestampType::Native from the provided [`NaiveDateTime`] | ||
| /// | ||
| /// See [`DataType::Timestamp`] for more information on timezone handling | ||
| fn make_value(naive: NaiveDateTime) -> Option<i64>; |
There was a problem hiding this comment.
This is the fix for #4033
tustvold
commented
Apr 7, 2023
| let array = array.as_string::<O>(); | ||
| let out: PrimitiveArray<T> = match to_tz { | ||
| Some(tz) => { | ||
| let tz: Tz = tz.as_ref().parse()?; |
There was a problem hiding this comment.
This is the fix for #1936
tustvold
commented
Apr 7, 2023
| "2022-12-31 20:35:06".to_string(), | ||
| ] | ||
| ); | ||
| // Non-absolute timestamps should be parsed preserving the same local instant |
There was a problem hiding this comment.
More background on this can be found in #1936, in particular #1936 (comment)
alamb
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
Makes sense to me. Cc @waitingkuo @avantgardnerio and @doki23
|
Thank you @tustvold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1936
Closes #4033
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
This is technically a breaking change to functionality added in #3673 by @comphead, I'm inclined to think this is ok.