Add ListArray Constructors (#3879) #4065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
list-array-constructors
branch
2 times, most recently
from
291433f to
67f7016
Compare
tustvold
changed the title
tustvold
force-pushed
the
list-array-constructors
branch
from
8f78a26 to
9b61c62
Compare
tustvold
commented
Apr 12, 2023
| @@ -104,6 +113,11 @@ mod tests { | |||
| OffsetBuffer::new(vec![-1, 0, 1].into()); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn offsets() { | |||
| OffsetBuffer::new(vec![0, 1, 2, 3].into()); | |||
There was a problem hiding this comment.
It is kinda embarrassing that this slipped through 😅
tustvold
force-pushed
the
list-array-constructors
branch
from
bdd68be to
185c095
Compare
alamb
reviewed
Apr 14, 2023
alamb
approved these changes
Apr 16, 2023
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3879
Closes #4066
Rationale for this change
Adds constructors for ListArray
What changes are included in this PR?
Are there any user-facing changes?