feat: Support dyn_compare_scalar for Decimal256 #4084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tustvold! I understand the problem regarding i256 arithmetic. My decision works with the numbers below i128::MAX, so I think if that problem would be solved we be able to make the complete solution. I added the corresponding test with expected behavior. |
tustvold
reviewed
Apr 13, 2023
|
|
||
| #[test] | ||
| fn test_decimal256_scalar_i256() { | ||
| let a = Decimal256Array::from_iter_values( |
There was a problem hiding this comment.
Suggested change
| let a = Decimal256Array::from_iter_values( | |
| // TODO: Support i256 scalars (#2837) | |
| let a = Decimal256Array::from_iter_values( |
tustvold
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4083
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
Yes