Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the file path in the error message when failed to open credentials file for GCS #4124

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

haoxins
Copy link
Contributor

@haoxins haoxins commented Apr 25, 2023

Which issue does this PR close?

no

Rationale for this change

Improve the error message

What changes are included in this PR?

Will display the file path when open GCS credentials file failed in the object_store

The error will now look like this

thread 'main' panicked at 'Generic GCS error: GCP credential error: Unable to open service account file from /Users/***/***-361845.json: No such file or directory (os error 2)'

Are there any user-facing changes?

no

@github-actions github-actions bot added the object-store Object Store Interface label Apr 25, 2023
@haoxins haoxins force-pushed the display-file-path-in-err-msg branch from b855161 to 7801a8f Compare April 25, 2023 14:08
@haoxins haoxins changed the title Display the file path in the error message when failed to open credentials file for GCP object store Display the file path in the error message when failed to open credentials file for GCS Apr 25, 2023
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, you could possibly add a test but don't feel strongly

@tustvold tustvold merged commit b981921 into apache:master Apr 25, 2023
@haoxins haoxins deleted the display-file-path-in-err-msg branch April 26, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants