Allow format specification in cast #4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
reviewed
May 5, 2023
arrow-cast/src/cast.rs
Outdated
| @@ -947,8 +956,8 @@ pub fn cast_with_options( | |||
| x as f64 / 10_f64.powi(*scale as i32) | |||
| }) | |||
| } | |||
| Utf8 => value_to_string::<i32>(array), | |||
| LargeUtf8 => value_to_string::<i64>(array), | |||
| Utf8 => value_to_string::<i32>(array, None), | |||
There was a problem hiding this comment.
This is a decimal to string and FormatOptions only has format specifiers for temporal types. I don't see a need to specify format for decimal since the display is precisely determined by the precision and scale.
There was a problem hiding this comment.
I think for consistency and avoiding surprises in the future it would be better to pass it through consistently
There was a problem hiding this comment.
I've added the format option for decimal types as well, but decimal_display will drop this option.
I don't know if there is a standard or common way to specify a format string for decimals used by other engines, but I'll take a look at it sometime.
tustvold
approved these changes
May 9, 2023
|
Thank you |
|
Thank you @tustvold for the review and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4168
Rationale for this change
See issue #4168
What changes are included in this PR?
Adds a
FormatOptionfield toCastOption. If specified, the format is passed in to the formatter which will then output in the required format.One change was to modify
DEFAULT_CAST_OPTIONSso that it is no longer aconst. Instead it implements theDefaulttrait in keeping with the implementation ofFormatOptionsAre there any user-facing changes?
The cast API is not changed but the cast options are. This should be documented.
Not sure if this is a breaking change, but adding the api-change label to be on the safe side.