Fix ImdsManagedIdentityProvider (#4096) #4193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
May 10, 2023
| @@ -383,16 +392,16 @@ struct MsiTokenResponse { | |||
| /// This authentication type works in Azure VMs, App Service and Azure Functions applications, as well as the Azure Cloud Shell | |||
| /// <https://learn.microsoft.com/en-gb/azure/active-directory/managed-identities-azure-resources/how-to-use-vm-token#get-a-token-using-http> | |||
| #[derive(Debug)] | |||
| pub struct ImdsManagedIdentityOAuthProvider { | |||
| pub struct ImdsManagedIdentityProvider { | |||
There was a problem hiding this comment.
I removed the OAuth part from the name to highlight that this isn't an OAuth flow
tustvold
commented
May 10, 2023
| @@ -424,7 +433,7 @@ impl TokenCredential for ImdsManagedIdentityOAuthProvider { | |||
| ) -> Result<TemporaryToken<String>> { | |||
| let mut query_items = vec
roeap
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4096
Rationale for this change
Originally added by @roeap in #3581 I don't think this has ever worked correctly. Crucially the metadata communication is not an OAuth2 flow, and consequently does not deal with scopes, only resource IDs.
I have confirmed this now works correctly
What changes are included in this PR?
Are there any user-facing changes?