Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test_list_root on OS X (#3772) #4198

Merged
merged 3 commits into from
May 11, 2023
Merged

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #3772

Rationale for this change

I think this fixes the issue in #3772, but as I can't actually reproduce the issue I'm not sure 😅

@alamb perhaps you might be able to see if this placates whatever OS X nonsense is occurring.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the object-store Object Store Interface label May 11, 2023
@tustvold tustvold requested a review from alamb May 11, 2023 12:27
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly it still fails like the following for me

cargo test -p object_store

---- local::tests::test_list_root stdout ----
thread 'local::tests::test_list_root' panicked at 'called `Result::unwrap()` on an `Err` value: Generic { store: "LocalFileSystem", source: UnableToWalkDir { source: Error { depth: 1, inner: Io { path: None, err: Os { code: 1, kind: PermissionDenied, message: "Operation not permitted" } } } } }', src/local.rs:1141:44
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    local::tests::test_list_root

I pushed a commit that made it works for me

@tustvold tustvold changed the title Skip test_list_root if cannot list root filesystem (#3772) Skip test_list_root on OS X (#3772) May 11, 2023
@tustvold tustvold merged commit d6c3c01 into apache:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[object_store] local::tests::test_list_root test fails during release verification
2 participants