-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor lexico sort for future code reuse #423
Conversation
c9e23b1
to
efef737
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jimexist ! Ready to go in my opinion
not sure what i can do about the docker build failures |
efef737
to
a0ba084
Compare
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
==========================================
- Coverage 82.64% 82.64% -0.01%
==========================================
Files 162 162
Lines 44542 44549 +7
==========================================
+ Hits 36813 36817 +4
- Misses 7729 7732 +3
Continue to review full report at Codecov.
|
seems like rebasing just solved this issue |
I think that causes the tests to get re-run and thus if the error was due to some network glitch or something it will be solved by the re-execution |
Which issue does this PR close?
Re #428
Rationale for this change
the logic to sort a list of columns lexicographically given sort options was previously embedded within
lexsort
but this pull request changes to pull that part out to a generic struct for future code reuse.This change is used in #424
What changes are included in this PR?
Are there any user-facing changes?