Treat legacy TIMSETAMP_X converted types as UTC #4309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if you think user-facing impact is acceptable and I can try to align the tests with this change. |
|
This change seems fine to me, thank you |
sergiimk
force-pushed
the
bug/treat_legacy_timestamps_as_utc
branch
from
0df03b0 to
69e8fba
Compare
sergiimk
force-pushed
the
bug/treat_legacy_timestamps_as_utc
branch
from
69e8fba to
ff1d152
Compare
|
Thanks for taking a look @tustvold, I've updated the tests and this PR should be ready for final review. |
tustvold
approved these changes
May 31, 2023
|
I've marked this API change, as whilst the prior behaviour was technically a bug, this will serve to highlight this change in the changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4308.
Are there any user-facing changes?
This will change the behavior for users who read Parquet produced by older systems that still use legacy converted types (e.g. Apache Spark is one of them), but it changes it to be aligned with Parquet spec.