Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed array_to_json_array to take &dyn Array #4370

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Changed array_to_json_array to take &dyn Array #4370

merged 3 commits into from
Jun 6, 2023

Conversation

dadepo
Copy link
Contributor

@dadepo dadepo commented Jun 5, 2023 •
edited
Loading

Which issue does this PR close?

Closes #4369

Are there any user-facing changes?

Yes but not a breaking change. array_to_json_array can now, also be called without wrapping with an Arc

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 5, 2023
@dadepo dadepo marked this pull request as ready for review June 6, 2023 04:17
@tustvold tustvold added the api-change Changes to the arrow API label Jun 6, 2023
@tustvold
Copy link
Contributor

tustvold commented Jun 6, 2023

Thank you for this, marking it API change as it is technically, although I expect the fallout to be minimal

@tustvold tustvold merged commit 6c742c7 into apache:master Jun 6, 2023
@dadepo dadepo deleted the array_to_json_array_dyn_array branch June 6, 2023 06:11
@alamb alamb mentioned this pull request Jun 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changed array_to_json_array to take &dyn Array
2 participants
@dadepo @tustvold