Add MapArray constructors and doc example #4382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
map-array-constructors
branch
from
140cd9b to
e3fc71a
Compare
viirya
reviewed
Jun 7, 2023
arrow-array/src/array/list_array.rs
Outdated
| @@ -103,7 +104,7 @@ impl<OffsetSize: OffsetSizeTrait> GenericListArray<OffsetSize> { | |||
| let len = offsets.len() - 1; // Offsets guaranteed to not be empty | |||
| let end_offset = offsets.last().unwrap().as_usize(); | |||
| // don't need to check other values of `offsets` because they are checked | |||
| // during construction of `OffsetsbBuffer` | |||
| // during construction of `OffsetsBuffer` | |||
There was a problem hiding this comment.
Suggested change
| // during construction of `OffsetsBuffer` | |
| // during construction of `OffsetBuffer` |
viirya
reviewed
Jun 7, 2023
arrow-array/src/array/map_array.rs
Outdated
| } | ||
| if field.is_nullable() || entries.null_count() != 0 { | ||
| return Err(ArrowError::InvalidArgumentError( | ||
| "MapArray entries cannot contain be null".to_string(), |
There was a problem hiding this comment.
Suggested change
| "MapArray entries cannot contain be null".to_string(), | |
| "MapArray entries cannot contain null".to_string(), |
viirya
reviewed
Jun 7, 2023
arrow-array/src/array/map_array.rs
Outdated
| let len = offsets.len() - 1; // Offsets guaranteed to not be empty | ||
| let end_offset = offsets.last().unwrap().as_usize(); | ||
| // don't need to check other values of `offsets` because they are checked | ||
| // during construction of `OffsetsBuffer` |
There was a problem hiding this comment.
Suggested change
| // during construction of `OffsetsBuffer` | |
| // during construction of `OffsetBuffer` |
tustvold
force-pushed
the
map-array-constructors
branch
from
030a38c to
d52e101
Compare
tustvold
commented
Jun 8, 2023
| /// [`MapArray`] is physically a [`ListArray`] of key values pairs stored as an `entries` | ||
| /// [`StructArray`] with 2 child fields. | ||
| /// | ||
| /// See [`MapBuilder`](crate::builder::MapBuilder) for how to construct a [`MapArray`] |
There was a problem hiding this comment.
I didn't see a compelling reason to duplicate the example already on MapBuilder
alamb
changed the title
alamb
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4385
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?