Add multiply_fixed_point_scalar and multiply_fixed_point_scalar_checked #4468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
commented
Jun 29, 2023
viirya
force-pushed
the
multiply_fixed_point_scalar
branch
2 times, most recently
from
f170968
to
88342e1
Compare
viirya
force-pushed
the
multiply_fixed_point_scalar
branch
from
ae446cb
to
8781c7c
Compare
|
I'm not sure what the long-term plan for these kernels is, as of apache/datafusion#6832 DataFusion won't make use of them... How would you like to proceed here? |
|
Hmm, I'd like to close this. In worst case, we may need to replace decimal kernels internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
This adds scalar kernels for fixed point decimal multiplication. It will be used in cases like #apache/datafusion#6794.
What changes are included in this PR?
Are there any user-facing changes?