Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object_store: Export ClientConfigKey and add HttpBuilder::with_config #4516

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

thehabbos007
Copy link
Contributor

Which issue does this PR close?

Closes #4515

Rationale for this change

The changes here are to enable more consistent use of the different providers in the object_store crate. It would be useful for polars to have access to this to make implementing http more consistent with the rest. See https://github.com/pola-rs/polars/blob/96b0e07e75a882eaed7be05e619307bc144aa5b4/polars/polars-core/src/cloud.rs

What changes are included in this PR?

  • Exporting ClientConfigKey
  • Add HttpBuilder::with_config

Are there any user-facing changes?

There are user facing changes, but not breaking. The addition has been documented.

@github-actions github-actions bot added the object-store Object Store Interface label Jul 13, 2023
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, my only thought is whether we would potentially in the future want to add options unique to the HttpStore and not found on ClientOptions. This would entail a HttpConfigKey or something, I don't feel strongly either way

@thehabbos007
Copy link
Contributor Author

Yeah, that was an alternative considered in the issue linked. I think that would be ideal, but for I don't expect there to be special casing for HTTP. Could be in the future, though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

object_store: Export ClientConfigKey and make the HttpBuilder more consistent with other builders
2 participants