Add ability to reuse Rows
in encoder
#4533
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4479
Rationale for this change
When converting many (many!) record batches I would like to avoid the overhead of allocating / zeroing out temporary allocations. See #4479 for more details
What changes are included in this PR?
Add
RowConverter::set_target
API to reuse an existingRows
when callingRowConverter:: convert_columns
If this is an acceptable API I will write some tests
Are there any user-facing changes?