Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy lints introduced in rust 1.53 #469

Closed
wants to merge 3 commits into from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 19, 2021

Which issue does this PR close?

Closes #467

I started on getting clippy CI running again but ran out of time this morning. Will finish up tomorrow if no one beats me to it

Rationale for this change

Rust upgrade cases lots of clippy errors

What changes are included in this PR?

Do what clippy says

Are there any user-facing changes?

No

@codecov-commenter
Copy link

Codecov Report

Merging #469 (7b14af8) into master (1f1c637) will increase coverage by 0.00%.
The diff coverage is 99.64%.

❗ Current head 7b14af8 differs from pull request most recent head 57b5cb6. Consider uploading reports for the commit 57b5cb6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #469   +/-   ##
=======================================
  Coverage   82.65%   82.66%           
=======================================
  Files         165      165           
  Lines       45563    45556    -7     
=======================================
- Hits        37662    37657    -5     
+ Misses       7901     7899    -2     
Impacted Files Coverage Δ
parquet/src/arrow/array_reader.rs 77.31% <ø> (ø)
arrow/src/json/reader.rs 84.01% <97.56%> (+0.10%) ⬆️
arrow/src/array/array_binary.rs 90.13% <100.00%> (ø)
arrow/src/array/array_boolean.rs 90.90% <100.00%> (ø)
arrow/src/array/array_dictionary.rs 84.56% <100.00%> (ø)
arrow/src/array/array_primitive.rs 94.70% <100.00%> (ø)
arrow/src/array/array_struct.rs 88.43% <100.00%> (ø)
arrow/src/array/array_union.rs 86.93% <100.00%> (ø)
arrow/src/array/builder.rs 85.90% <100.00%> (ø)
arrow/src/array/equal/mod.rs 93.58% <100.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f1c637...57b5cb6. Read the comment docs.

@jimexist
Copy link
Member

jimexist commented Jun 19, 2021

I started on getting clippy CI running again but ran out of time this morning. Will finish up tomorrow if no one beats me to it

😄 I got the similar fix in #470

@Dandandan
Copy link
Contributor

Closed by #470

@Dandandan Dandandan closed this Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clippy broken after upgrade to rust 1.53
4 participants