Take kernel dyn Array #4705
Merged
Take kernel dyn Array #4705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Aug 16, 2023
Comment on lines
+748
to
+752
| to_indices_identity!(UInt32Type); | ||
| to_indices_reinterpret!(Int32Type, UInt32Type); | ||
|
|
||
| to_indices_identity!(UInt64Type); | ||
| to_indices_reinterpret!(Int64Type, UInt64Type); |
There was a problem hiding this comment.
32-bit and 64-bit indices are both relatively common and I think justify having separate specializations
tustvold
commented
Aug 16, 2023
Comment on lines
+742
to
+746
| to_indices_widening!(UInt8Type, UInt32Type); | ||
| to_indices_widening!(Int8Type, UInt32Type); | ||
|
|
||
| to_indices_widening!(UInt16Type, UInt32Type); | ||
| to_indices_widening!(Int16Type, UInt32Type); |
There was a problem hiding this comment.
8-bit and 16-bit indices are very rare in my experience, if this becomes a performance issue for people we can easily change the specializations based on that feedback
crepererum
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Having the take kernel accept a dyn Array achieves a couple of things:
AnyDictionaryabstractionWhat changes are included in this PR?
Are there any user-facing changes?
This is a breaking change to the take kernel, but most code will not notice