Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove stale comment on ArrayData equality and update unit tests #472

Merged
merged 1 commit into from
Jun 19, 2021

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Jun 19, 2021

Which issue does this PR close?

Closes #.

Rationale for this change

remove stale comment and update unit tests, because equality for ArrayData is implemented

What changes are included in this PR?

Are there any user-facing changes?

@jimexist jimexist changed the title remove stale comment and update unit tests remove stale comment on ArrayData equality and update unit tests Jun 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2021

Codecov Report

Merging #472 (7c5beb9) into master (60fedf7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7c5beb9 differs from pull request most recent head 1b83439. Consider uploading reports for the commit 1b83439 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
- Coverage   82.66%   82.65%   -0.01%     
==========================================
  Files         165      165              
  Lines       45550    45524      -26     
==========================================
- Hits        37653    37628      -25     
+ Misses       7897     7896       -1     
Impacted Files Coverage Δ
arrow/src/array/array_struct.rs 87.84% <100.00%> (-0.59%) ⬇️
arrow/src/array/builder.rs 85.78% <100.00%> (-0.13%) ⬇️
parquet/src/encodings/encoding.rs 95.04% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60fedf7...1b83439. Read the comment docs.

Copy link
Contributor

@nevi-me nevi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge this after a rebase

@jimexist jimexist force-pushed the remove-stale-comment branch from 49b03d1 to 1b83439 Compare June 19, 2021 15:38
@nevi-me nevi-me merged commit 6e2f684 into apache:master Jun 19, 2021
@jimexist jimexist deleted the remove-stale-comment branch June 19, 2021 17:05
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

alamb added a commit that referenced this pull request Jun 23, 2021
Co-authored-by: Jiayu Liu <Jimexist@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants