Clear row buffer before reuse #4742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
reviewed
Aug 26, 2023
arrow-row/src/lib.rs
Outdated
| @@ -981,6 +981,9 @@ impl Rows { | |||
| /// Sets the length of this [`Rows`] to 0 | |||
| pub fn clear(&mut self) { | |||
| self.offsets.truncate(1); | |||
| unsafe { | |||
There was a problem hiding this comment.
self.buffer.clear()` I think would achieve the same thing?
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4741.
Rationale for this change
When reusing rows buffer, previous rows' fixed-length field content isn't cleared, causing the
Rowto become incomparable if a null value is written for the new row.What changes are included in this PR?
Fill the
Rowsbuffer with zero to keep the row comparable after buffer reuse.Are there any user-facing changes?
No.