Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport clippy fixes to active release #475

Merged
merged 2 commits into from
Jun 20, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 20, 2021

Which issue does this PR close?

Rationale:

Backports #470 / #467 to active_release (aka arrow 4.4) so I can get clean CI runs for other backported changes

Changes:

git cherry-pick  60fedf7011e15578b2f5e6fd6e3486f4e01b2ee2

And then manually resolve some conflicts

cc @jimexist

jimexist and others added 2 commits June 20, 2021 06:54
* fix clippy warnings for rust 1.53

* update readme
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2021

Codecov Report

Attention: Patch coverage is 98.61111% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.69%. Comparing base (1f7f4bc) to head (9225249).

Files with missing lines Patch % Lines
parquet/src/arrow/array_reader.rs 57.14% 3 Missing ⚠️
arrow/src/json/reader.rs 97.56% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           active_release     #475   +/-   ##
===============================================
  Coverage           82.69%   82.69%           
===============================================
  Files                 163      163           
  Lines               44775    44762   -13     
===============================================
- Hits                37025    37017    -8     
+ Misses               7750     7745    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jimexist jimexist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb alamb merged commit 153085f into apache:active_release Jun 20, 2021
@alamb alamb deleted the alamb/backport_clippy branch June 20, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants