-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed RAT check. #482
Fixed RAT check. #482
Conversation
Notice that I made it such that it uses the I am not sure whether this is sufficient, though; I assume that archery just calls the Regardless, imo this is better than what we have, where we currently do not even check for the headers of |
Build log on my repo after removing the license from
|
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
==========================================
- Coverage 82.65% 82.65% -0.01%
==========================================
Files 165 165
Lines 45556 45524 -32
==========================================
- Hits 37655 37628 -27
+ Misses 7901 7896 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great -- thank you @jorgecarleitao
Closes #481