Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick remove unnecessary wraps in sort to active_release #483

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 22, 2021

Automatic cherry-pick of efe86cd

@codecov-commenter
Copy link

Codecov Report

Merging #483 (148daa4) into active_release (b5e50ef) will decrease coverage by 0.01%.
The diff coverage is 52.38%.

❗ Current head 148daa4 differs from pull request most recent head b6f7e5e. Consider uploading reports for the commit b6f7e5e to get more accurate results
Impacted file tree graph

@@                Coverage Diff                 @@
##           active_release     #483      +/-   ##
==================================================
- Coverage           82.72%   82.70%   -0.02%     
==================================================
  Files                 163      163              
  Lines               44802    44813      +11     
==================================================
+ Hits                37061    37062       +1     
- Misses               7741     7751      +10     
Impacted Files Coverage Δ
arrow/src/compute/kernels/sort.rs 94.11% <52.38%> (-0.86%) ⬇️
parquet/src/encodings/encoding.rs 95.04% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5e50ef...b6f7e5e. Read the comment docs.

@jhorstmann
Copy link
Contributor

Looks good. The only signature changes are for private functions so should be compatible.

@alamb alamb merged commit 563a506 into active_release Jun 23, 2021
@alamb alamb deleted the cherry_pick_efe86cdf branch June 23, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants