Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushdown list_with_offset for GCS #4993

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Noticed whilst working on #4984, GCS exposes the same list API as S3 and so we can support this parameter in the same way

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the object-store Object Store Interface label Oct 25, 2023
@tustvold
Copy link
Contributor Author

It would appear our mock GCS server doesn't handle this correctly :( - I did confirm this works against GCS proper though

@crepererum
Copy link
Contributor

As far as I can tell, we're using an emulator image that you've built. Did you update that image recently? Seems like the upstream project is rather active and might have fixed that issue already.

@tustvold
Copy link
Contributor Author

Still waiting on fsouza/fake-gcs-server#1164

The activity seems to mostly be dependabot

@tustvold
Copy link
Contributor Author

fsouza/fake-gcs-server@46f2f72 fixes the upstream to support this

@tustvold tustvold merged commit e4bb1e9 into apache:master Oct 30, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants