Default AWS region to us-east-1 (#5211) #5244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Dec 26, 2023
| pub fn with_access_key_id(mut self, access_key_id: impl Into<String>) -> Self { | ||
| self.access_key_id = Some(access_key_id.into()); | ||
| self | ||
| } | ||
|
|
||
| /// Set the AWS Secret Access Key (required) | ||
| /// Set the AWS Secret Access Key |
There was a problem hiding this comment.
This is a drive-by fix as these are no longer required (we support other forms of credential)
tustvold
commented
Dec 26, 2023
| pub fn with_secret_access_key(mut self, secret_access_key: impl Into<String>) -> Self { | ||
| self.secret_access_key = Some(secret_access_key.into()); | ||
| self | ||
| } | ||
|
|
||
| /// Set the region (e.g. `us-east-1`) (required) | ||
| /// Set the AWS Session Token to use for requests | ||
| pub fn with_token(mut self, token: impl Into<String>) -> Self { |
There was a problem hiding this comment.
This is moved up from lower down, to sit alongside the credentials it relates to. I also tweaked the doc to make it a bit clearer.
|
FYI @ritchie46 |
|
Ah, nice one. Thanks for the heads up. Can remove my temporary workaround. ^^ |
7 tasks
This was referenced Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5211
Closes #3827
Rationale for this change
This has come up a number of times, and appears to cause friction for people using S3-compatible stores.
Most of such stores either support any region, or at the very least "us-east-1", and so we can default to
us-east-1:What changes are included in this PR?
Are there any user-facing changes?