Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eq for struct #5423

Closed
wants to merge 8 commits into from
Closed

eq for struct #5423

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2560c5b
eq for struct
jayzhan211 Feb 23, 2024
052c4e1
ops on buffer
jayzhan211 Feb 24, 2024
deab05c
clippy
jayzhan211 Feb 24, 2024
1eb8d43
fold
jayzhan211 Feb 24, 2024
4b7257f
new_set
jayzhan211 Feb 24, 2024
5c19581
try fold
jayzhan211 Feb 24, 2024
c283e5e
null handling
jayzhan211 Feb 24, 2024
e71384c
fix test
jayzhan211 Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 93 additions & 2 deletions arrow-ord/src/cmp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,38 @@ fn compare_op(op: Op, lhs: &dyn Datum, rhs: &dyn Datum) -> Result<BooleanArray,
let r = r_v.map(|x| x.values().as_ref()).unwrap_or(r);
let r_t = r.data_type();

if l_t != r_t || l_t.is_nested() {
if l_t != r_t {
return Err(ArrowError::InvalidArgumentError(format!(
"Invalid comparison operation: {l_t} {op} {r_t}"
)));
}

if let Struct(_) = l_t {
let l = l.as_struct();
let r = r.as_struct();
assert_eq!(l.num_columns(), r.num_columns());
match op {
Op::Equal => {
let mut res = vec![true; len];
for i in 0..l.num_columns() {
let col_l = l.column(i);
let col_r = r.column(i);
let eq_rows = compare_op(op, col_l, col_r)?;
for (j, item) in res.iter_mut().enumerate().take(len) {
Copy link
Contributor

@tustvold tustvold Feb 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be faster to compute the bitwise and of the underlying buffers, than to do this element wise

Something like

let nulls = NullBuffer::union(l.nulls(), r.nulls());
let vals = l.values () & r.values();
BooleanArray::new(vals, nulls)

In combination with Iterator::fold

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy told me to use try_fold instead, but it is so difficult to work with try_fold.

*item &= eq_rows.value(j);
}
}
return Ok(BooleanArray::from(res));
}
_ => {
return Err(ArrowError::NotYetImplemented(format!(
"Op for struct is not yet implemented: {op}"
)));
}
}
}

if l_t.is_nested() {
return Err(ArrowError::InvalidArgumentError(format!(
"Invalid comparison operation: {l_t} {op} {r_t}"
)));
Expand Down Expand Up @@ -544,10 +575,70 @@ impl<'a> ArrayOrd for &'a FixedSizeBinaryArray {
mod tests {
use std::sync::Arc;

use arrow_array::{DictionaryArray, Int32Array, Scalar, StringArray};
use arrow_array::{
DictionaryArray, Float32Array, Int32Array, Scalar, StringArray, StructArray,
};

use super::*;

#[test]
fn test_struct_eq() {
let s1 = StructArray::try_from(vec![
(
"a",
Arc::new(Int32Array::from(vec![1, 2, 3, 4, 5])) as Arc<dyn Array>,
),
(
"b",
Arc::new(Float32Array::from(vec![1.0, 2.0, 3.0, 4.0, 5.0])) as Arc<dyn Array>,
),
])
.unwrap();
let s2 = StructArray::try_from(vec![
(
"a",
Arc::new(Int32Array::from(vec![1, 2, 3, 4, 5])) as Arc<dyn Array>,
),
(
"b",
Arc::new(Float32Array::from(vec![1.0, 2.0, 3.0, 4.0, 5.0])) as Arc<dyn Array>,
),
])
.unwrap();

let res = eq(&s1, &s2).unwrap();
assert_eq!(res, BooleanArray::from(vec![true; 5]));

let s1 = StructArray::try_from(vec![
(
"a",
Arc::new(Int32Array::from(vec![1, 2, 3, 4, 5])) as Arc<dyn Array>,
),
(
"b",
Arc::new(Float32Array::from(vec![1.0, 2.0, 3.0, 4.0, 5.0])) as Arc<dyn Array>,
),
])
.unwrap();
let s2 = StructArray::try_from(vec![
(
"a",
Arc::new(Int32Array::from(vec![10, 20, 30, 4, 5])) as Arc<dyn Array>,
),
(
"b",
Arc::new(Float32Array::from(vec![1.0, 2.0, 3.0, 4.0, 5.0])) as Arc<dyn Array>,
),
])
.unwrap();

let res = eq(&s1, &s2).unwrap();
assert_eq!(
res,
BooleanArray::from(vec![false, false, false, true, true])
);
}

#[test]
fn test_null_dict() {
let a = DictionaryArray::new(Int32Array::new_null(10), Arc::new(Int32Array::new_null(0)));
Expand Down
Loading