Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose path_to_filesystem public #5441

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Expose path_to_filesystem public #5441

merged 1 commit into from
Feb 29, 2024

Conversation

metesynnada
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

In our fork, we use a wrapper to LocalFileSystem. If this is OK for everyone, making path_to_filesystem public will ease our process.

What changes are included in this PR?

Move path_to_filesystem into LocalFileSystem and make it public.

Are there any user-facing changes?

No

@github-actions github-actions bot added the object-store Object Store Interface label Feb 28, 2024
tustvold
tustvold approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me, I think the mechanism for converting between Path and PathBuf is pretty stable these days.

CI failure is an unrelated localstack flake

@tustvold tustvold merged commit ed996da into master Feb 29, 2024
13 checks passed
@alamb alamb deleted the local-public-expose branch January 27, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
object-store Object Store Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metesynnada @tustvold