Update triplet.rs to support REPEATED field with null value at one place #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update triplet.rs to support REPEATED field with null value at one time
Codecov Report
@@ Coverage Diff @@
## master #556 +/- ##
==========================================
- Coverage 82.47% 82.47% -0.01%
==========================================
Files 167 167
Lines 46144 46145 +1
==========================================
Hits 38059 38059
- Misses 8085 8086 +1
Continue to review full report at Codecov.
|
alamb
changed the title
|
Thank you @aiglematth for the contribution |
alamb
pushed a commit
that referenced
this pull request
Jul 20, 2021
Update triplet.rs to support REPEATED field with null value at one time
alamb
added a commit
that referenced
this pull request
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update triplet.rs to support REPEATED field with null value at one place
Which issue does this PR close?
No
Rationale for this change
Used to manage REPEATED fields with null values. Drill generates it for example when creating the parquet.
What changes are included in this PR?
Replace the assert statement by an if statement that return a
Field::Nullvalue in thepub fn current_value(&self) -> Fieldlocate in record/triplet.rs.Are there any user-facing changes?
No