Add try_filter_leaves to propagate error from filter closure
#5575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
viirya
force-pushed
the
filter_leaves_error
branch
from
34bc7f9
to
8690239
Compare
viirya
force-pushed
the
filter_leaves_error
branch
from
8690239
to
55e42b2
Compare
|
Perhaps we could add a try_filter_leaves to avoid this being a breaking change, filter_leaves could just call this with unwrap |
Sounds good to me. Let me update this later. |
viirya
changed the title
filter_leaves.try_filter_leaves to propagate error from filter closure
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5574.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?