Introduce Compare to support nulls comparison
#5672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
jayzhan211
commented
Apr 21, 2024
| } | ||
|
|
||
| #[inline] | ||
| pub fn is_null(&self) -> bool { |
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
|
As stated on the ticket, this needs more thought as it won't work for distinct, it is on my list to work out a way to support this but I haven't had time recently. Edit: it is possible I just had a brain fart, I think we should mock up something showing this works for distinct and then we can move forward with this. We should probably double check this doesn't regress the lexsort benchmarks as well |
tustvold
reviewed
Apr 21, 2024
| /// Compare the values at two arbitrary indices in two arrays. | ||
| pub type DynComparator = Box<dyn Fn(usize, usize) -> Ordering + Send + Sync>; | ||
| pub type DynComparator = Box<dyn Fn(usize, usize) -> Compare + Send + Sync>; |
There was a problem hiding this comment.
Currently this will be a breaking change, we might want to make this change additive and deprecate DynComparator instead
tustvold
reviewed
Apr 21, 2024
| @@ -725,16 +726,19 @@ impl LexicographicalComparator { | |||
| None => (true, true), | |||
| }; | |||
|
|
|||
| // TODO: after dict values with nulls are supported, we can compare with | |||
There was a problem hiding this comment.
I think this will probably be necessary to avoid this change regressing the performance of lexsort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
First step of #5426, support existing comparator, exclude list
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?