fix: undefined behavior in schema ffi #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes apache#580 Signed-off-by: roee88 <roee88@gmail.com>
alamb
reviewed
Jul 21, 2021
There was a problem hiding this comment.
FWIW when I tested this change locally with MIRI it passed the tests that were previously failing
alamb@MacBook-Pro arrow-rs % git cherry-pick 7e5f4d1285baacfe56bbf4026cea6bb2da873bb1
git cherry-pick 7e5f4d1285baacfe56bbf4026cea6bb2da873bb1
Auto-merging arrow/src/ffi.rs
[alamb/validate_output_of_miri 1d075e2e2] fix: undefined behavior in schema ffi
Author: roee88 <roee88@gmail.com>
Date: Wed Jul 21 15:33:51 2021 +0300
1 file changed, 6 insertions(+), 3 deletions(-)
alamb@MacBook-Pro arrow-rs % MIRIFLAGS="-Zmiri-disable-isolation" cargo +nightly miri test -p arrow -- --ignored ffi
MIRIFLAGS="-Zmiri-disable-isolation" cargo +nightly miri test -p arrow -- --ignored ffi
WARNING: Ignoring `RUSTC_WRAPPER` environment variable, Miri does not support wrapping.
Compiling arrow v6.0.0-SNAPSHOT (/Users/alamb/Software/arrow-rs/arrow)
Finished test [unoptimized + debuginfo] target(s) in 3.04s
Running unittests (target/miri/x86_64-apple-darwin/debug/deps/arrow-111eb02f3e835a62)
running 6 tests
test array::ffi::tests::test_struct ... ok
test datatypes::ffi::tests::test_field ... ok
test datatypes::ffi::tests::test_schema ... ok
test datatypes::ffi::tests::test_type ... ok
test ffi::tests::test_large_list ... ok
test ffi::tests::test_list ... ok
test result: ok. 6 passed; 0 failed; 0 ignored; 0 measured; 760 filtered out
Doc-tests arrow
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 103 filtered out; finished in 0.01s
alamb
approved these changes
Jul 21, 2021
Codecov Report
@@ Coverage Diff @@
## master #582 +/- ##
==========================================
- Coverage 82.46% 82.45% -0.01%
==========================================
Files 167 167
Lines 46205 46205
==========================================
- Hits 38101 38100 -1
- Misses 8104 8105 +1
Continue to review full report at Codecov.
|
|
https://github.com/apache/arrow-rs/pull/582/checks?check_run_id=3123911024 Shows: 👍 |
|
Thank you so much @roee88 |
alamb
pushed a commit
that referenced
this pull request
Jul 21, 2021
Closes #580 Signed-off-by: roee88 <roee88@gmail.com>
alamb
added a commit
that referenced
this pull request
Jul 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #580
Rationale for this change
The undefined behavior that was fixed in #323 was re-introduced in #439.
This PR attempts to re-introduce the same fix.