-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doctests for UnionBuilder and UnionArray. #603
Conversation
Codecov Report
@@ Coverage Diff @@
## master #603 +/- ##
==========================================
+ Coverage 82.41% 82.42% +0.01%
==========================================
Files 167 167
Lines 46232 46257 +25
==========================================
+ Hits 38100 38126 +26
+ Misses 8132 8131 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @novemberkilo
In terms of completing the documentation, I looked at all the things that implemented Array
here: https://docs.rs/arrow/5.0.0/arrow/array/trait.Array.html#implementors
I think https://docs.rs/arrow/5.0.0/arrow/array/type.LargeBinaryArray.html and https://docs.rs/arrow/5.0.0/arrow/array/type.BinaryArray.html are stll missing examples, but othrwise it is looking good.
Thanks so much @novemberkilo
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@alamb I will add examples for |
Great -- Thank you @novemberkilo -- feel free to reopen #301 if you want or just mention it. Again, I really appreciate your help in this area, and I think future users will as well. 👍 |
* Doctests for UnionBuilder and UnionArray. * Update arrow/src/array/array_union.rs Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
* Doctests for UnionBuilder and UnionArray. * Update arrow/src/array/array_union.rs Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> Co-authored-by: Navin <navin@novemberkilo.com>
Which issue does this PR close?
Closes #301.
(@alamb do you concur that this PR closes the issue. Or have I missed an array type that could use a doctest?)
What changes are included in this PR?
Repurposes existing examples for
UnionBuilder
and putting them into doctests.Adds some documentation for
UnionArray
Are there any user-facing changes?
No