Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct timeout in comment from 5s to 30s #6073

Merged
merged 1 commit into from
Jul 17, 2024
+6 −6
Merged

Correct timeout in comment from 5s to 30s #6073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions object_store/src/client/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ impl ClientOptions {
/// The timeout is applied from when the request starts connecting until the
/// response body has finished
///
/// Default is 5 seconds
/// Default is 30 seconds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed -- I double checked and the value is set here:

https://github.com/apache/arrow-rs/pull/6073/files#diff-88d0f948b3d41b30e5432864ce5882e2aac9e1df0be2875ea7b455742f5c4529R212

pub fn with_timeout(mut self, timeout: Duration) -> Self {
self.timeout = Some(ConfigValue::Parsed(timeout));
self
Expand Down Expand Up @@ -435,23 +435,23 @@ impl ClientOptions {
///
/// This is the length of time an idle connection will be kept alive
///
/// Default is 90 seconds
/// Default is 90 seconds enforced by reqwest
pub fn with_pool_idle_timeout(mut self, timeout: Duration) -> Self {
self.pool_idle_timeout = Some(ConfigValue::Parsed(timeout));
self
}

/// Set the maximum number of idle connections per host
///
/// Default is no limit
/// Default is no limit enforced by reqwest
pub fn with_pool_max_idle_per_host(mut self, max: usize) -> Self {
self.pool_max_idle_per_host = Some(max.into());
self
}

/// Sets an interval for HTTP2 Ping frames should be sent to keep a connection alive.
///
/// Default is disabled
/// Default is disabled enforced by reqwest
pub fn with_http2_keep_alive_interval(mut self, interval: Duration) -> Self {
self.http2_keep_alive_interval = Some(ConfigValue::Parsed(interval));
self
Expand All @@ -462,7 +462,7 @@ impl ClientOptions {
/// If the ping is not acknowledged within the timeout, the connection will be closed.
/// Does nothing if http2_keep_alive_interval is disabled.
///
/// Default is disabled
/// Default is disabled enforced by reqwest
pub fn with_http2_keep_alive_timeout(mut self, interval: Duration) -> Self {
self.http2_keep_alive_timeout = Some(ConfigValue::Parsed(interval));
self
Expand All @@ -473,7 +473,7 @@ impl ClientOptions {
/// If disabled, keep-alive pings are only sent while there are open request/response
/// streams. If enabled, pings are also sent when no streams are active
///
/// Default is disabled
/// Default is disabled enforced by reqwest
pub fn with_http2_keep_alive_while_idle(mut self) -> Self {
self.http2_keep_alive_while_idle = true.into();
self
Expand Down
Loading