-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract parquet statistics for StructArray #6090
base: main
Are you sure you want to change the base?
Conversation
closing/reopening to rerun ci |
cbd6eac
to
3d285d9
Compare
I am depressed about the large review backlog in this crate. We are looking for more help from the community reviewing PRs -- see #6418 for more |
1 similar comment
I am depressed about the large review backlog in this crate. We are looking for more help from the community reviewing PRs -- see #6418 for more |
i'm interested in this topic, but not too aquantanted to the source code of this crate yet, give me more time and i can share some review load! |
(None, None), | ||
]), | ||
|
||
expected_max: struct_array(vec![ | ||
(Some(true), Some(3)), | ||
(Some(true), Some(0)), | ||
(Some(true), Some(5)), | ||
(None, None), | ||
]), | ||
}; | ||
// Due to https://github.com/apache/datafusion/issues/8334, | ||
// statistics for struct arrays are not supported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we remove this comment after this was resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
(None, None), | ||
]), | ||
|
||
expected_max: struct_array(vec![ | ||
(Some(true), Some(3)), | ||
(Some(true), Some(0)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
original values was
(Some(true), Some(0)),
(Some(false), Some(5)),
(None, None),
Then isn't min should be Some(false), Some(5)
and max should be Some(true),Some(0)
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?