Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make FFI_ArrowArray::empty() public #612

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Conversation

wangfenjin
Copy link
Contributor

@wangfenjin wangfenjin commented Jul 25, 2021

Same as FFI_ArrowSchema::empty(), we should also make FFI_ArrowArray::empty() public, which makes it easy to create empty struct and query from FFI library.

close #602

Change-Id: I9e6672ad8c1419481cb8a063f2af3a2f53cf16cd
@github-actions github-actions bot added the arrow Changes to the arrow crate label Jul 25, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #612 (59db75a) into master (87d2840) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
+ Coverage   82.41%   82.42%   +0.01%     
==========================================
  Files         167      167              
  Lines       46232    46257      +25     
==========================================
+ Hits        38100    38126      +26     
+ Misses       8132     8131       -1     
Impacted Files Coverage Δ
arrow/src/ffi.rs 87.07% <0.00%> (ø)
arrow/src/array/ord.rs 63.33% <0.00%> (ø)
arrow/src/compute/kernels/substring.rs 98.27% <0.00%> (ø)
arrow/src/array/builder.rs 86.26% <0.00%> (+0.15%) ⬆️
arrow/src/compute/kernels/partition.rs 97.65% <0.00%> (+0.15%) ⬆️
parquet/src/encodings/encoding.rs 95.04% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d2840...59db75a. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me -- any thoughts @jorgecarleitao or @nevi-me ?

@alamb
Copy link
Contributor

alamb commented Jul 26, 2021

Thank you @wangfenjin !

@alamb alamb merged commit 42a7163 into apache:master Jul 27, 2021
alamb pushed a commit that referenced this pull request Jul 27, 2021
Change-Id: I9e6672ad8c1419481cb8a063f2af3a2f53cf16cd
alamb added a commit that referenced this pull request Jul 28, 2021
Change-Id: I9e6672ad8c1419481cb8a063f2af3a2f53cf16cd

Co-authored-by: Wang Fenjin <wangfenj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make FFI_ArrowArray empty() public
4 participants