Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctests for BinaryArray and LargeBinaryArray. #625

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

novemberkilo
Copy link
Contributor

Which issue does this PR close?

Closes #301.

What changes are included in this PR?

Doctests for BinaryArray and LargeBinaryArray

Are there any user-facing changes?

No.

// @alamb

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jul 28, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #625 (e17ff0d) into master (87d2840) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
+ Coverage   82.41%   82.48%   +0.07%     
==========================================
  Files         167      167              
  Lines       46232    46452     +220     
==========================================
+ Hits        38100    38315     +215     
- Misses       8132     8137       +5     
Impacted Files Coverage Δ
arrow/src/array/array_binary.rs 92.23% <ø> (ø)
parquet/src/arrow/arrow_array_reader.rs 77.65% <0.00%> (-0.47%) ⬇️
arrow/src/ipc/writer.rs 86.22% <0.00%> (-0.46%) ⬇️
arrow/src/buffer/ops.rs 96.77% <0.00%> (-0.20%) ⬇️
arrow/src/ipc/reader.rs 84.21% <0.00%> (-0.10%) ⬇️
arrow/src/compute/util.rs 97.80% <0.00%> (-0.05%) ⬇️
arrow/src/array/ord.rs 63.33% <0.00%> (ø)
arrow-flight/src/utils.rs 0.00% <0.00%> (ø)
arrow/src/array/array_union.rs 89.26% <0.00%> (ø)
arrow/src/compute/kernels/cast.rs 94.53% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d2840...e17ff0d. Read the comment docs.

@alamb alamb added the documentation Improvements or additions to documentation label Jul 28, 2021
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thank you @novemberkilo ❤️

@alamb alamb merged commit 6e1dbb4 into apache:master Jul 28, 2021
alamb added a commit that referenced this pull request Jul 29, 2021
Co-authored-by: Navin <navin@novemberkilo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More examples of how to construct Arrays
3 participants