Parquet: Verify 32-bit CRC checksum when decoding pages

[xmakro]

Closes #6289

Please let me know if we should expose this in the reader APIs instead of a crate feature

[tustvold]

Can we get some tests phase

[alamb]

I agree with @tustvold that this code needs to have some tests to ensure we don't break the feature in the future

Also I think the feature flag should be documented here https://crates.io/crates/parquet

[mapleFU]

FYI: https://github.com/apache/parquet-testing/tree/master/data
You can check the file with filename contains "checksum"

[xmakro]

Thanks for the pointers. I added the tests and documented the feature flag. Please take a look

[alamb]

I am depressed about the large review backlog in this crate. We are looking for more help from the community reviewing PRs -- see #6418 for more

[etseidl]

Thanks for this! Please run cargo +stable fmt --all and check in the result. Have you run any benchmarks to see if there is a measurable impact from the crc calculation?

[etseidl]

Thanks @xmakro! Looks good to me. I'm fine with this as a feature, but will defer to others who may have a stronger opinion.

[Jefffrey]

Looks good to me 👍

Probably just need to clarify wording on the feature flag.

CI failure looks unrelated, will try look into it.

Edit: looks like CI failure was resolved by #6437. Merging in latest from master should resolve the issue

[xmakro]

Thanks for the reviews! I applied the comments and merged master, PTAL

[alamb]

🚀

[alamb]

Thanks everyone