Add support for BinaryView in arrow_string::length #6359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Sep 9, 2024
| @@ -85,6 +85,14 @@ pub fn length(array: &dyn Array) -> Result<ArrayRef, ArrowError> { | |||
| DataType::FixedSizeBinary(len) | DataType::FixedSizeList(_, len) => Ok(Arc::new( | |||
| Int32Array::new(vec![*len; array.len()].into(), array.nulls().cloned()), | |||
| )), | |||
| DataType::BinaryView => { | |||
| let list = array.as_binary_view(); | |||
| let v = list.views().iter().map(|v| *v as i32).collect::<Vec<_>>(); | |||
alamb
approved these changes
Sep 9, 2024
arrow-string/src/length.rs
Outdated
| @@ -224,6 +232,18 @@ mod tests { | |||
| length_binary_helper!(i64, Int64Array, length, value, result) | |||
| } | |||
|
|
|||
| #[test] | |||
| fn length_test_binary_view() { | |||
| let value: Vec<&[u8]> = vec![b"zero", &[0xff, 0xf8], b"two"]; | |||
There was a problem hiding this comment.
Can you please add a test value that has more than 12 bytes (which ends up running a different code path)?
alamb
approved these changes
Sep 10, 2024
| b"zero", | ||
| &[0xff, 0xf8], | ||
| b"two", | ||
| b"this is a longer string to test binary array with", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6358
Rationale for this change
Adding additional functionality
What changes are included in this PR?
Code, test.
Are there any user-facing changes?
No.