Update lexical-core requirement from ^0.8 to ^1.0 #6401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [lexical-core](https://github.com/Alexhuszagh/rust-lexical) to permit the latest version. - [Release notes](https://github.com/Alexhuszagh/rust-lexical/releases) - [Changelog](https://github.com/Alexhuszagh/rust-lexical/blob/main/CHANGELOG) - [Commits](Alexhuszagh/rust-lexical@v0.8.0...1.0.1) --- updated-dependencies: - dependency-name: lexical-core dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
crepererum
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
CI passes and this crate is only used for internals, not for Rust APIs, so it's safe to bump. Also fixes https://rustsec.org/advisories/RUSTSEC-2023-0086 .
crepererum
requested changes
Sep 16, 2024
6 tasks
|
@Jefffrey filed #6397 and @dariocurr has made a PR to upgrade #6402 Let's go with one of them |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
bot
deleted the
dependabot/cargo/master/lexical-core-tw-1.0
branch
Wumpf
pushed a commit
to rerun-io/rerun
that referenced
this pull request
Sep 16, 2024
### What * Waiting for a proper fix in apache/arrow-rs#6401 * Should be fixed before #3741 is considered finished ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7426?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7426?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7426) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on lexical-core to permit the latest version.
Commits
e3f01cbMerge pull request #142 from Alexhuszagh/optunsafe559a1cfDon't worry about skipping checks with an overallocated buffer.89f6b67Update documentation and make method names more expressive.4313694Merge pull request #141 from Alexhuszagh/optunsafe222009eFix some performance regressions (#140).7778b93Move the safety guarantees for for decimal writing inside.efb7a1bAdd in some better conventions, refactor more to safe fns.b21ffccImprove some naming conventions, etc.fbeb026Add some better naming conventions and plan to migrate for less unsafe code.b40a7feMerge pull request #139 from Alexhuszagh/optunsafeDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)